Commit
Signed-off-by: Scott Hain <shain@chef.io>
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ | |
| # | ||
|
|
||
| name "git" | ||
| default_version "2.10.2" | ||
|
|
||
| license "LGPL-2.1" | ||
| license_file "LGPL-2.1" | ||
|
|
@@ -30,6 +30,10 @@ | |
|
|
||
| relative_path "git-#{version}" | ||
|
|
||
| version "2.10.2" do | ||
| source md5: "45e8b30a9e7c1b734128cc0fc6663619" | ||
| end | ||
|
|
||
| version "2.8.2" do | ||
| source md5: "3022d8ebf64b35b9704d5adf54b256f9" | ||
| end | ||
|
|
@@ -117,6 +121,9 @@ | |
| # old style -R for libraries and as a result, xlc will ignore it. In this case, we | ||
| # we want that to happen because we explicitly set the libpath with the correct | ||
| # command line argument in omnibus itself. | ||
| if version.satisfies?(">=2.10.2") | ||
| config_hash["NO_REGEX"] = "NeedsStartEnd" | ||
| end | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
thommay
Contributor
|
||
| else | ||
| # Linux things! | ||
| config_hash["HAVE_PATHS_H"] = "YesPlease" | ||
|
|
||
I'm a developer on the git project who's worked on code related to this feature. This looks like you're overriding the libc regex library in some generic chef recipe, e.g. if this is distributed to Linux systems it's needlessly skipping using the glibc regex implementation, which is generally better than the compat engine shipped with git which this'll invoke. Are you sure you want to do that?