This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Allow opscode_pushy_server vip to be overridden #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, a user cannot leverage push jobs with a highly available chef server configuration. By allowing a user to set the `opscode_pushy_server['vip']` this pull request allows users to override the default values assigned by Chef, allowing push jobs to be leveraged with highly available chef server configurations. As `opscode_pushy_server['vip'] defaults to `nil`, this should only affect users that have been instructed to make these changes explicitly. Signed-off-by: Josh O'Brien <jobrien@chef.io>
markan
approved these changes
Aug 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, a user cannot leverage push jobs with a highly available chef server
configuration. By allowing a user to set the
opscode_pushy_server['vip']thispull request allows users to override the default values assigned by Chef, allowing
push jobs to be leveraged with highly available chef server configurations. As
opscode_pushy_server['vip']defaults tonil, this should only affect usersthat have been instructed to make these changes explicitly.
Signed-off-by: Josh O'Brien jobrien@chef.io