This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Jsinha/just try #195
Merged
Jsinha/just try #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaymala Sinha <jsinha@chef.io>
Signed-off-by: Mark Anderson <mark@chef.io>
Signed-off-by: Mark Anderson <mark@chef.io>
Signed-off-by: Mark Anderson <mark@chef.io>
3 tasks
|
https://buildkite.com/chef/chef-opscode-pushy-server-master-omnibus-adhoc/builds/18 passes. Awesome work, thanks @markan 👍 |
btm
reviewed
Apr 5, 2019
| @@ -35,7 +35,6 @@ | |||
| pushy_job :: tuple(), | |||
| incarnation_id :: binary(), | |||
| requestor :: binary(), | |||
| max_body_size :: binary(), | |||
There was a problem hiding this comment.
is this a functionality regression @markan ? what was/is the state of that attempt?
There was a problem hiding this comment.
It was just broken code. We were keeping it in the state record of the web request, but never updating and instead fetching it separately from config. So might as well just strip that out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update rubies, and get build/tests working again
Replaces #194
Issues Resolved
Check List