Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to prevent security warnings when using HTTPS #528

Closed
miketheman opened this issue Jul 1, 2014 · 3 comments
Closed

Attempt to prevent security warnings when using HTTPS #528

miketheman opened this issue Jul 1, 2014 · 3 comments

Comments

@miketheman
Copy link
Contributor

When visiting a page that displays external images, such as badges, a security warning is displayed to the user via a yellow triangle on the SSL badge. See https://supermarket.getchef.com/cookbooks/apt for an example.
The badges for this page are at http://img.shields.io/* and can definitely be rewritten to https on the backend.
This will not cover/handle all cases, so possibly one solution is to attempt to rewrite the header to https, and display a "insecure image" instead, or some other solution.

@brettchalupa
Copy link
Contributor

@miketheman good catch & suggestions, I have added them to the Supermarket Trello board: https://trello.com/c/MOZhgNZ7

@sethvargo
Copy link
Contributor

@raskchanky
Copy link
Contributor

The fix for this was merged and will go to production soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants