support of windows guests #59
Conversation
|
@jarig This is awesome! I'm AFK today but will take a deeper review ASAP. |
|
@jarig any chance you can take a look at and address the Travis CI failures also? |
|
rake test:unit works on my machine, but fails to start in Travis, that seems to be following Vagrant issue which appears on 64bit linux machines: |
|
So finally figured what the issue is. Log4r 1.1.11 was released (and yanked). This version changed the arity of it's constructor in a patch release which broke core vagrant. For some reason Travis is still pulling down log4r 1.1.11 though! Anyway thanks for fixing some of the Rubocop errors. I'm going to pull your changes into a branch a do a little more cleanup to fix the rest of the Rubocop issues and then merge. |
|
Closing this as I opened #60 which contains these changes plus a few more. |
Windows guest support.
Unit tests and acceptance tests passed on Win8 and Win2k8(tried only with virtualbox provider).