Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SID instead of hard-coded system accounts #68

Closed
jugatsu opened this issue Sep 28, 2018 · 3 comments
Closed

Add support for SID instead of hard-coded system accounts #68

jugatsu opened this issue Sep 28, 2018 · 3 comments

Comments

@jugatsu
Copy link

jugatsu commented Sep 28, 2018

Description

For better support of localized versions of Windows, it would be better to use SID to determine if account actually system or not. Instead of hard-coded values
https://github.com/chef/win32-taskscheduler/blob/ole/lib/win32/windows/constants.rb#L4

For example on Russian version of Windows system account is 'СИСТЕМА', on French it's alslo localized, for example.

chef/chef#7679

@Vasu1105
Copy link

Vasu1105 commented Oct 3, 2018

Thank you @jugatsu @Nimesh-Msys is working on this. So once we fix this we can have a look at your PR on windows_task as fix needs to be done on both the sides. We also identified task registration issue with BUILTIN\Users so we will be handling same here.

@Nimesh-Msys
Copy link
Contributor

Thank you @jugatsu @Nimesh-Msys is working on this. So once we fix this we can have a look at your PR on windows_task as fix needs to be done on both the sides. We also identified task registration issue with BUILTIN\Users so we will be handling same here.

Right, I've started working on it. Will make some changes in this PR and update you shortly.
Thank you

@jugatsu
Copy link
Author

jugatsu commented Oct 11, 2018

Closed by #69

@jugatsu jugatsu closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants