Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

median windows does not agree with R #3

Closed
kjappelbaum opened this issue Sep 4, 2020 · 3 comments
Closed

median windows does not agree with R #3

kjappelbaum opened this issue Sep 4, 2020 · 3 comments

Comments

@kjappelbaum
Copy link
Collaborator

it is closer if we choose the half window size in R
@kjappelbaum
Copy link
Collaborator Author

The reason seems to be the running median implementation we use. It does not agree with runmed of R

@kjappelbaum
Copy link
Collaborator Author

We should implement it ourselves, it is actually a question on Leetcode :https://leetcode.com/problems/sliding-window-median/ 🤣

@kjappelbaum
Copy link
Collaborator Author

works now within 2%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjappelbaum