Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nmredataToJSON): fix the exportation of 2D signal #15

Merged
merged 3 commits into from
May 4, 2021

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented May 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #15 (6203811) into master (853417c) will increase coverage by 0.31%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   55.39%   55.71%   +0.31%     
==========================================
  Files          23       23              
  Lines         713      718       +5     
  Branches      204      205       +1     
==========================================
+ Hits          395      400       +5     
  Misses        255      255              
  Partials       63       63              
Impacted Files Coverage Δ
src/converter/util/toJSON/getSignalData2D.js 10.00% <ø> (ø)
src/converter/util/toJSON/getJcamp.js 50.00% <50.00%> (ø)
src/NmrRecord.js 58.65% <100.00%> (+0.81%) ⬆️
src/converter/nmredataToJSON.js 96.77% <100.00%> (+0.34%) ⬆️
src/converter/util/toJSON/extractZipFolder.js 89.47% <100.00%> (ø)
src/parseSignal/parse1DSignal.js 94.87% <100.00%> (ø)
src/parseSignal/parse2DSignal.js 75.00% <100.00%> (ø)
src/processContent.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0d2b6...6203811. Read the comment docs.

@jobo322 jobo322 merged commit ab25b7c into master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant