feat: generate blob for the spectra from an outside component #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nmrium ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Implementation LGTM but can we find a better name for the exposed method? |
I really do not know, this is what comes to my mind, we can call it getView() or something similar |
|
The name can contain the word "Blob" because it's part of what is returned, but I think it should also have a hint about what the blob contains (an image? of what?) |
|
getSpectraViewerBlob or generateSpectraViewerBlocb ? |
|
|
|
@targos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@targos
we use useImperativeHandle to customize the instance value that is exposed to parent components when using ref so it is possible to call the generate a Blob function, and then they can do whatever they need with this blob, to store it in the database or save as png or svg ... etc in an external file server.
#1569