Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search in database by molecule structure #1602

Merged
merged 5 commits into from Jul 1, 2022
Merged

feat: search in database by molecule structure #1602

merged 5 commits into from Jul 1, 2022

Conversation

hamed-musallam
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jun 30, 2022 •
edited

✅ Deploy Preview for nmrium ready!

Name Link
🔨 Latest commit ac7c910
🔍 Latest deploy log https://app.netlify.com/sites/nmrium/deploys/62bebf0d2178970008d35527
😎 Deploy Preview https://deploy-preview-1602--nmrium.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

lpatiny
lpatiny requested changes Jul 1, 2022
View reviewed changes
Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preparing the database is relatively slow and we should not do it onload but only the first time we open the substructure search dialog.

src/data/data1d/database.ts Outdated Show resolved Hide resolved
src/data/data1d/database.ts Show resolved Hide resolved
lpatiny
lpatiny reviewed Jul 1, 2022
View reviewed changes
src/data/data1d/database.ts Outdated Show resolved Hide resolved
@hamed-musallam hamed-musallam merged commit fed6872 into master Jul 1, 2022
@hamed-musallam hamed-musallam deleted the database-advance-search branch July 1, 2022 13:26
@cheminfo-bot cheminfo-bot mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatiny lpatiny Awaiting requested review from lpatiny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hamed-musallam @lpatiny