Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: live preview for baseline correction #1621

Merged
merged 5 commits into from
Jul 15, 2022

Conversation

hamed-musallam
Copy link
Member

@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for nmrium ready!

Name Link
🔨 Latest commit 5d6fe8f
🔍 Latest deploy log https://app.netlify.com/sites/nmrium/deploys/62cf26b67d7ccb000845384a
😎 Deploy Preview https://deploy-preview-1621--nmrium.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lpatiny
Copy link
Member

lpatiny commented Jul 13, 2022

I tried with polynomial correction and each time I add a zone I expect to see new corrected spectrum but it does not work.

2022-07-13 07 00 00

@hamed-musallam
Copy link
Member Author

@lpatiny this is another story, I made the live update just when change the options in the header. I will implement it also when you add zones

@lpatiny
Copy link
Member

lpatiny commented Jul 13, 2022

Functionality is ok now. But why when we click on baseline correction we have vertical rescale. Quite annoying this and I would prefer it does not happen.

@hamed-musallam
Copy link
Member Author

@lpatiny

can you test it again?

@hamed-musallam
Copy link
Member Author

hamed-musallam commented Jul 13, 2022

@lpatiny

can you test this PR again and also check the phase correction?

@lpatiny
Copy link
Member

lpatiny commented Jul 13, 2022

Why was this PR closed ?

There is still a little problem of zoom out in case you don't apply the changes.

@hamed-musallam
Copy link
Member Author

@lpatiny

It is closed by mistake.

@hamed-musallam
Copy link
Member Author

@lpatiny
Do you mean when we press cancel? is this in all the filters or just in the baseline correction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants