fix: round data to dataPoints reported

[jobo322]

close: #1635

[netlify]

✅ Deploy Preview for nmrium ready!

Name	Link
🔨 Latest commit	775fdd9
🔍 Latest deploy log	https://app.netlify.com/sites/nmrium/deploys/62f2e129080aa900084629ad
😎 Deploy Preview	https://deploy-preview-1685--nmrium.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[lpatiny]

This code change nothing right ? Just optimization ?

Could you also change the x variable so that it is a Float64Array ?

Could you also avoid the .map for data.im. We have a utility to multiply a xArray

Could you add a comment to this function. What is CSD ? (should this method be renamed ?)

[lpatiny]

Ok I understood. It is the length of the array that is based on dimension.count and not on the buffer anymore.

[targos]

I feel like this code should be somewhere in the parser, not in nmrium

[lpatiny]

Yes I agree. @jobo322 why is this code not in nmr-parser ?

We have a lot of changes in the data structure in NMRium while the goal on nmr-parser is to avoid this seems to me.

nmrium/src/data/SpectraManager.ts

Lines 95 to 111 in 94e9d90

	let converted = fromJEOL(jdf, {});
	converted = converted[0];
	let info = converted.description;
	let metadata = info.metadata;
	delete info.metadata;
	info.acquisitionMode = 0;
	info.experiment = info.dimension === 1 ? '1d' : '2d';
	info.type = 'NMR SPECTRUM';
	info.nucleus = info.nucleus[0];
	info.numberOfPoints = info.numberOfPoints[0];
	info.acquisitionTime = info.acquisitionTime[0];
	info.baseFrequency = info.baseFrequency[0];
	info.frequencyOffset = info.frequencyOffset[0];
	info.spectralWidthClipped = converted.application.spectralWidthClipped;

In nmr-load-save do we still plan to use nmr-parser ?

[jobo322]

nmr-load-save will export the nmrium format

[jobo322]

Ok I understood. It is the length of the array that is based on dimension.count and not on the buffer anymore.

@lpatiny yes, dimension.count could be bigger than buffer length (small difference), so the idea is to fill with zeros.

Is strange that count and data length do not match, julien did use count and he was working with a guy that understands JEOL data.