-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import NMReData not working #1735
Comments
Thanks for the report. Confirmed the bug with the "Full cytisine" example: https://www.swisstransfer.com/d/805f32a5-5b8e-4b0e-b105-aae28a64cf6b |
There was some changes that broke the nmredata exportation (we don't keep the original data anymore). I am working on nmredata to use filelist-utils instead of an jsZip instance to support the nmredata importation by the package nmr-load-save,. we could check how to fix the export to nmredata. I think we could generate champ files of each spectrum at the moment of witte the nmrRecord file. @targos @lpatiny what do you think? |
For now I think that we should disable NMReData exportation. We will see how to use of filelist helps in order to be able to export the original data and we should keep in mind that if possible we should track where is the original data. |
For testing please consider the following example as well |
@jobo322 Is this example working in the next release of NMRium using filelist ? If yes you could close this isssue in the related PR. |
@targos the SDF file looks like
I need to check if an empty line between tags (> <NMREDATA_...) is mandatory or not. The nmredata parser uses this empty line as a delimitation to group the tag data. So adding this empty line between nmredata tags. the file is correctly imported. https://www.swisstransfer.com/d/e77a20b8-09c2-499f-8c07-d99b5c4832eb |
We close this issue because the file is corrupted. |
I have exported NMReData with NMRium (from a jdx file) and tried to open it again but it didn't work.
The text was updated successfully, but these errors were encountered: