support for inline jcamp from nmr-load-save #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nmrium ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
targos
reviewed
Oct 21, 2022
jobo322
force-pushed
the
1812-json-with-inline-jcamp-file
branch
from
dc9ace0
to
5a9639c
Compare
targos
reviewed
Oct 25, 2022
targos
reviewed
Oct 25, 2022
jobo322
force-pushed
the
1812-json-with-inline-jcamp-file
branch
from
dd5f6fa
to
e1b70a8
Compare
use readNMRiumObject instead fromJSON
add a cache in readNMRiumObject
jobo322
force-pushed
the
1812-json-with-inline-jcamp-file
branch
from
e1b70a8
to
e7a8270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use readNMRiumObject instead fromJSON
close: #1813 #1812 #1811 #1782