fix: assignments #2322
Merged
fix: assignments #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hamed-musallam
commented
Apr 26, 2023
•
hamed-musallam
commented
- Assignment and floating molecule #2313
- Assignment issues #2311
Closed
|
in the old code, there is something strange for me why do we have to remove the range nbAtoms if we remove the signals assignments, currently, i stopped this code because the range could be assigned to atoms different than the one that the signals have. |
Deploying with
|
| Latest commit: |
ff67b1f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b15fa1d.nmrium.pages.dev |
| Branch Preview URL: | https://fix-assignment.nmrium.pages.dev |
hamed-musallam
force-pushed
the
fix-assignment
branch
from
7c912ca
to
6b23367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.