Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integral value editing if the sum 0 #2464

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

hamed-musallam
Copy link
Member

No description provided.

@hamed-musallam hamed-musallam linked an issue Jun 26, 2023 that may be closed by this pull request
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: facb06a
Status: ✅  Deploy successful!
Preview URL: https://bcac67d3.nmrium.pages.dev
Branch Preview URL: https://fix-integral-to-0-prevent-ed.nmrium.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 3.33% and project coverage change: -0.07 ⚠️

Comparison is base (0bc6183) 52.08% compared to head (facb06a) 52.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2464      +/-   ##
==========================================
- Coverage   52.08%   52.01%   -0.07%     
==========================================
  Files          52       52              
  Lines        2546     2557      +11     
  Branches       84       84              
==========================================
+ Hits         1326     1330       +4     
- Misses       1217     1225       +8     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
...1d/Spectrum1D/integrals/changeIntegralsRelative.ts 11.76% <0.00%> (+0.33%) ⬆️
...ta1d/Spectrum1D/ranges/changeRangeRelativeValue.ts 32.55% <6.66%> (-1.66%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos
Copy link
Member

targos commented Jun 26, 2023

Does it fix this error:

Cannot read properties of undefined (reading 'options')

{
  source: 'webpack://_N_E/node_modules/nmrium/lib/component/reducer/actions/IntegralsActions.js',
  line: 16,
  column: 8,
  name: 'setSumOptions'
}
{
  source: 'webpack://_N_E/node_modules/nmrium/lib/data/data1d/Spectrum1D/SumManager.js',
  line: 33,
  column: 0,
  name: 'options'
}

as i remember it should be fixed too

@lpatiny
Copy link
Member

lpatiny commented Jun 30, 2023

If you go through zero and then set a value from a line the sum is NaN

2023-06-30 14 19 25

@hamed-musallam hamed-musallam merged commit e6d6e0a into main Jul 6, 2023
9 of 12 checks passed
@hamed-musallam hamed-musallam deleted the fix-integral-to-0-prevent-edition branch July 6, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integral to 0 prevent edition
3 participants