feat: add new way to display peaks #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
23f6106
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9239863.nmrium.pages.dev |
| Branch Preview URL: | https://peaks-display-mode.nmrium.pages.dev |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2562 +/- ##
=======================================
Coverage 51.87% 51.87%
=======================================
Files 52 52
Lines 2562 2562
Branches 85 85
=======================================
Hits 1329 1329
Misses 1231 1231
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
You may invert the logic so that by default it displays the peak values on the top and when you click on the toggle it would display the value just over the peak. |
|
Is the edit mode still necessary in the new display mode? It appears that you intend to set it as the primary display mode |
targos
reviewed
Aug 3, 2023
|
The tests are not passing but the functionality looks ok to me. |
hamed-musallam
force-pushed
the
peaks-display-mode
branch
from
dde59db
to
2e8867e
Compare
targos
reviewed
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.