Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 2d shift filter #2594

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

hamed-musallam
Copy link
Member

No description provided.

@hamed-musallam hamed-musallam linked an issue Aug 8, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (795ace9) 51.87% compared to head (84fe589) 51.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2594   +/-   ##
=======================================
  Coverage   51.87%   51.87%           
=======================================
  Files          52       52           
  Lines        2562     2562           
  Branches       85       85           
=======================================
  Hits         1329     1329           
  Misses       1231     1231           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos
Copy link
Member

targos commented Aug 8, 2023

You're fixing a critical bug. Don't use "chore" for the commit message.

@hamed-musallam
Copy link
Member Author

You're fixing a critical bug. Don't use "chore" for the commit message.

I will squash and merge this PR so the name of the PR i prefixed it with fix

@targos
Copy link
Member

targos commented Aug 8, 2023

well, be careful when you merge, because by default GitHub takes the message of the commit.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 84fe589
Status: ✅  Deploy successful!
Preview URL: https://960ed683.nmrium.pages.dev
Branch Preview URL: https://freezing-browser-when-changi.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the freezing-browser-when-changing-2d-reference branch from 5d66576 to 84fe589 Compare August 9, 2023 08:32
@hamed-musallam hamed-musallam merged commit b63fe93 into main Aug 9, 2023
12 checks passed
@hamed-musallam hamed-musallam deleted the freezing-browser-when-changing-2d-reference branch August 9, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freezing browser when changing 2D reference
2 participants