Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to ts522 #2670

Merged
merged 2 commits into from Sep 15, 2023
Merged

chore: update to ts522 #2670

merged 2 commits into from Sep 15, 2023

Conversation

lpatiny
Copy link
Member

@lpatiny lpatiny commented Sep 14, 2023

The issue with ml-spectra-processing is solved but we still have other issues:

src/component/toolbar/ToolBar.tsx:2:25 - error TS2307: Cannot find module 'react-science/ui' or its corresponding type declarations.

2 import { Toolbar } from 'react-science/ui';
                          ~~~~~~~~~~~~~~~~~~

src/utils/clipboard/clipboard.ts:2:10 - error TS1323: Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', or 'nodenext'.

2   return import('clipboard-polyfill').then((c) => c.readText());
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/utils/clipboard/clipboard.ts:6:10 - error TS1323: Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', or 'nodenext'.

6   return import('clipboard-polyfill').then((c) => c.read());
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/utils/clipboard/clipboard.ts:10:10 - error TS1323: Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', or 'nodenext'.

10   return import('clipboard-polyfill').then((c) => c.writeText(data));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/utils/clipboard/clipboard.ts:21:10 - error TS1323: Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', or 'nodenext'.

21   return import('clipboard-polyfill').then((c) => c.write(data));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            ```

@targos Could you advice ?

Does it make sense otherwise to remove the publication of commonJS ?

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 783c0d8
Status: ✅  Deploy successful!
Preview URL: https://ba0ce5af.nmrium.pages.dev
Branch Preview URL: https://ts522.nmrium.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3b6c060) 53.49% compared to head (783c0d8) 53.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          50       50           
  Lines        2449     2449           
  Branches       88       88           
=======================================
  Hits         1310     1310           
  Misses       1138     1138           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpatiny lpatiny requested a review from targos September 14, 2023 19:23
@lpatiny lpatiny marked this pull request as ready for review September 15, 2023 06:20
@cheminfo-bot
Copy link
Contributor

Published prerelease version 0.44.1-pre.1694759092 to npm.

To install it, run:

npm install --save-exact nmrium@0.44.1-pre.1694759092

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nmrium.org is ok with this change

Copy link
Member

@hamed-musallam hamed-musallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that it also works well on my end

@targos targos merged commit 82c871c into main Sep 15, 2023
14 checks passed
@targos targos deleted the ts522 branch September 15, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants