Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct ranges-preferences to generate acs string #2684

Merged

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Sep 18, 2023

No description provided.

@jobo322 jobo322 linked an issue Sep 18, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d310347) 53.49% compared to head (29fb9a2) 53.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2684   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          50       50           
  Lines        2449     2449           
  Branches       88       88           
=======================================
  Hits         1310     1310           
  Misses       1138     1138           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobo322 jobo322 force-pushed the 2676-general-preferences-not-used-to-generate-acs-string branch from cc92e89 to 99eded8 Compare September 19, 2023 12:14
@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 29fb9a2
Status: ✅  Deploy successful!
Preview URL: https://e7b0cc08.nmrium.pages.dev
Branch Preview URL: https://2676-general-preferences-not.nmrium.pages.dev

View logs

@jobo322 jobo322 changed the title use general preferences to generate acs string correct ranges-preferences to generate acs string Sep 19, 2023
@jobo322 jobo322 merged commit d7c2dc1 into main Sep 19, 2023
12 checks passed
@jobo322 jobo322 deleted the 2676-general-preferences-not-used-to-generate-acs-string branch September 19, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General preferences not used to generate ACS string
3 participants