chore: update react-science #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING-CHANGE: The NMRium component is no longer rendered inside an isolated shadow DOM. I depends on a style reset such as the one done by TailwindCSS (available in `react-science/styles/preflight.css`) to function correctly.
Deploying with
|
| Latest commit: |
b3bc8d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80b59bf3.nmrium.pages.dev |
| Branch Preview URL: | https://bye-bye-shadow-dom.nmrium.pages.dev |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
=======================================
Coverage 53.46% 53.46%
=======================================
Files 50 50
Lines 2450 2450
Branches 88 88
=======================================
Hits 1310 1310
Misses 1139 1139
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Thank you for your assistance. I have a question regarding the pre-release action. Has its functionality returned to work as before? I'm attending to create a pre-release for testing integration with another application. |
|
What do you mean by "returned to work as before" ? I'm not aware of any changes or problems with this action. |
hamed-musallam
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING-CHANGE: The NMRium component is no longer rendered inside an isolated
shadow DOM. It depends on a style reset such as the one done by TailwindCSS
(available in
react-science/styles/preflight.css) to function correctly.