Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading troubles #2752

Merged
merged 4 commits into from Nov 21, 2023
Merged

fix loading troubles #2752

merged 4 commits into from Nov 21, 2023

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Nov 17, 2023

No description provided.

@jobo322 jobo322 linked an issue Nov 17, 2023 that may be closed by this pull request
@jobo322 jobo322 changed the title fix loading throubles fix loading troubles Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (4f0626b) 53.65% compared to head (73b708a) 53.57%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/data/data2d/Spectrum2D/getSlice.ts 21.73% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
- Coverage   53.65%   53.57%   -0.09%     
==========================================
  Files          51       51              
  Lines        2462     2492      +30     
  Branches       88       88              
==========================================
+ Hits         1321     1335      +14     
- Misses       1140     1156      +16     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-pages bot commented Nov 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 73b708a
Status: ✅  Deploy successful!
Preview URL: https://eff48682.nmrium.pages.dev
Branch Preview URL: https://2751-spectra-not-loading-any.nmrium.pages.dev

View logs

@hamed-musallam
Copy link
Member

hamed-musallam commented Nov 20, 2023

We still have some issues

1- the carbon axis domain is wrong, and Does the error message supposed to show which files produces this error?
https://s3.uni-jena.de/nmrxiv/production/archive/5a1698da-4270-4114-b588-f258b9fd44d3/Apigenin%20annotated%20NMR%20400MHz%20DMSOd6%20data.zip

Screenshot 2023-11-20 at 09 33 37
Screenshot 2023-11-20 at 09 30 37

2- Problem with determination of gyromagnetic ratio

https://s3.uni-jena.de/nmrxiv/production/archive/2cd25088-4513-40ad-8aa6-21ff1f4e3527/%20Lupeol%20900MHz%20400MHz%20CDCl3%20NMR%20data%20.zip

Screenshot 2023-11-20 at 09 28 17

@hamed-musallam
Copy link
Member

@lpatiny
Should we open the logger window for the warning messages?
Screenshot 2023-11-20 at 09 36 38

@lpatiny
Copy link
Member

lpatiny commented Nov 20, 2023

@lpatiny Should we open the logger window for the warning messages? Screenshot 2023-11-20 at 09 36 38

I would keep only for error for now.

@hamed-musallam
Copy link
Member

hamed-musallam commented Nov 21, 2023

@jobo322

We identified an additional issue in the JCAMP parser, specifically, the proton and carbon JCAMP files are not loading

https://s3.uni-jena.de/nmrxiv/production/archive/a9d8c2a7-fc95-4eb6-84dd-107548aa0c48/12c_HEE296.zip

image

@jobo322 jobo322 force-pushed the 2751-spectra-not-loading-anymore branch from 53246ef to 73b708a Compare November 21, 2023 17:52
@hamed-musallam hamed-musallam merged commit 1a32500 into main Nov 21, 2023
11 of 13 checks passed
@hamed-musallam hamed-musallam deleted the 2751-spectra-not-loading-anymore branch November 21, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectra not loading anymore
3 participants