Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remap existing assignments when molecule is updated #2779

Merged
merged 1 commit into from Dec 1, 2023

Conversation

targos
Copy link
Member

@targos targos commented Dec 1, 2023

Closes: #1329

@targos targos requested a review from lpatiny December 1, 2023 14:22
Copy link

cloudflare-pages bot commented Dec 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5dc390
Status: ✅  Deploy successful!
Preview URL: https://dac11516.nmrium.pages.dev
Branch Preview URL: https://fix-diaid-edit.nmrium.pages.dev

View logs

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (683e511) 52.96% compared to head (b5dc390) 53.42%.

Files Patch % Lines
...ent/reducer/actions/utilities/deepReplaceDiaIDs.ts 90.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
+ Coverage   52.96%   53.42%   +0.45%     
==========================================
  Files          51       52       +1     
  Lines        2426     2456      +30     
  Branches       83       95      +12     
==========================================
+ Hits         1285     1312      +27     
- Misses       1140     1143       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpatiny lpatiny merged commit 840c3e5 into main Dec 1, 2023
13 checks passed
@lpatiny lpatiny deleted the fix-diaid-edit branch December 1, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If we edit the structure we loose assignment
2 participants