Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit range peaks #2953

Merged
merged 10 commits into from Mar 16, 2024
Merged

feat: edit range peaks #2953

merged 10 commits into from Mar 16, 2024

Conversation

hamed-musallam
Copy link
Member

No description provided.

Copy link

cloudflare-pages bot commented Mar 8, 2024

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: ddd2964
Status: ✅  Deploy successful!
Preview URL: https://6ccd8668.nmrium.pages.dev
Branch Preview URL: https://edit-range-peaks.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam marked this pull request as ready for review March 15, 2024 10:08
@lpatiny
Copy link
Member

lpatiny commented Mar 15, 2024

I added peaks manually but they don't appear in the spectrum even if I toggle the show peaks button.

image

When we click on a place we should keep all the digits of the chemical shift. It is only when we display that we should round the number. But this could be done later, not that important.

@lpatiny lpatiny merged commit bcddb6e into main Mar 16, 2024
11 checks passed
@lpatiny lpatiny deleted the edit-range-peaks branch March 16, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants