fix: improve consistency of labels #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not use uppercase in wrong places. - Remove unnecessary whitespaces. - Refactor Label component to wrap the form element with `<label>` to remove the need for `htmlFor` and automatically bind it to the element. - Drive-by: correct spelling error (spectrums instead of spectra).
Deploying nmrium with
|
| Latest commit: |
6e74248
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb18b8eb.nmrium.pages.dev |
| Branch Preview URL: | https://fix-label.nmrium.pages.dev |
|
I believe it's better to include a space before and after the shortcut label and capitalize the letter 'P' in 'Press'.
|
|
I can bring back the capital P, but in English there are no spaces inside parentheses. |
Yes, you're correct, but it was more readable than having no spaces. You can skip my comment, it is not important and you can keep it like that |
hamed-musallam
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<label>toremove the need for
htmlForand automatically bind it to the element.