Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please update compat bounds #175

Closed
CarloLucibello opened this issue Apr 4, 2024 · 6 comments
Closed

please update compat bounds #175

CarloLucibello opened this issue Apr 4, 2024 · 6 comments

Comments

@CarloLucibello
Copy link

There are a lot of unmerged CompatHelper PRs in this repo.
@chengchingwen could you update the compact bounds, in particular the latest Flux and NNlib version?

@johannes-fischer
Copy link

Any plans for this?

@svilupp
Copy link

svilupp commented Apr 25, 2024

EDIT: I am wrong -- it's an issue on 1.10, not Transfomers. I don't understand it, but it has to do with CUDA / GPUCompiler.


I believe this makes Transformers.jl uninstallable now.

I'm not sure how it's possible, but I've tried from fresh environment and it fails in resolving. Clearly, some dependency has moved on :/

Example

]activate --temp
]add Transformers@0.2.8

   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package GPUCompiler [61eb1bfa]:
 GPUCompiler [61eb1bfa] log:
 ├─possible versions are: 0.1.0-0.26.4 or uninstalled
 ├─restricted by julia compatibility requirements to versions: 0.22.0-0.26.4 or uninstalled
 └─restricted by compatibility requirements with CUDA [052768ef] to versions: 0.15.1-0.21.4 — no versions left
   └─CUDA [052768ef] log:
     ├─possible versions are: 0.1.0-5.3.1 or uninstalled
     ├─restricted by julia compatibility requirements to versions: [2.3.0, 2.5.0-5.3.1] or uninstalled
     ├─restricted by compatibility requirements with Transformers [21ca0261] to versions: 3.10.0-5.3.1
     │ └─Transformers [21ca0261] log:
     │   ├─possible versions are: 0.0.1-0.2.8 or uninstalled
     │   └─restricted to versions 0.2.8 by an explicit requirement, leaving only versions: 0.2.8
     └─restricted by compatibility requirements with Flux [587475ba] to versions: 3.0.0-4.4.2, leaving only versions: 3.10.0-4.4.2
       └─Flux [587475ba] log:
         ├─possible versions are: 0.4.1-0.14.15 or uninstalled
         └─restricted by compatibility requirements with Transformers [21ca0261] to versions: 0.13.4-0.13.17
           └─Transformers [21ca0261] log: see above

@johannes-fischer
Copy link

I think this is again an issue of the compat specification of Transformers.jl. On 1.10, only GPUCompiler 0.22.0 upwards are available (to my understanding because of this line). However, these never versions of GPUCompiler are only compatible with newer versions of CUDA.jl, but Transformers.jl restricts the CUDA version (explicitly, and implicitly via the Flux compat entry).

@cpfiffer
Copy link

I spent a bit trying to chase down the compat issues today and wow what an absolute nightmare.

  • GPUCompiler.jl is less of an issue thanks to this.
  • A bigger issue is NNlibCUDA.jl, which seems to be vaguely deprecated. Supposedly NNlib.jl contains all the functionality of NNlibCUDA.jl, but this may require some internal code changes and not just compat updates.

@cpfiffer
Copy link

Oh this is great, it doesn't seem like the package imports NNlibCUDA.jl anywhere, perhaps we can simply drop the compat. Experimenting.

@cpfiffer
Copy link

Opened #185, which should address some of this. Testing still ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants