Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code in npm is different than github repo #567

Closed
fabiulous opened this issue Apr 4, 2019 · 2 comments
Closed

Code in npm is different than github repo #567

fabiulous opened this issue Apr 4, 2019 · 2 comments

Comments

@fabiulous
Copy link

I got into an issue with setState in a unmounted component and tracked down the issue to this: #305

The 0.5.2 version in this repo has the following check in Motion, TransitionMotion and StaggeredMotion:

if (this.unmounting || this.animationID != null) {
  return;
}

I took a look at the code in my node_modules and noticed Motion doens't have the this.unmounting flag nor the code above.

I have 0.5.2 in my package.json and in node_modules/react-motion there's indeed 0.5.2 in package.json but there's 0.5.1 in bower.json

It looks like the code published in npm is outdated

@roderickhsiao
Copy link
Contributor

yes, we have a discussion

#509 (comment)

Will need the author or maintainer to help on this :)

@nkbt
Copy link
Collaborator

nkbt commented Feb 25, 2021

Latest updates were not published, please follow #569 (comment) thread for updates

@nkbt nkbt closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants