Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from os.ErrorString to os.NewError #2

Closed
GoogleCodeExporter opened this issue Oct 27, 2015 · 6 comments
Closed

Move from os.ErrorString to os.NewError #2

GoogleCodeExporter opened this issue Oct 27, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

To reflect recent Go API changes. 

I'm unable to do a merge request, don't know how that works on Google Code, 
here's the commit:

http://code.google.com/r/saschapeilicke-go-charset/source/detail?r=de31d93b0c0cf
dc8b7a617430bf595a85af1d93c

Original issue reported on code.google.com by sascha@peilicke.de on 25 Jun 2011 at 10:30

@GoogleCodeExporter
Copy link
Author

This one belongs to it too:
http://code.google.com/r/saschapeilicke-go-charset/source/detail?r=0d0d354c8e189
13fd850d868c16a839ff94beca9

Original comment by sascha@peilicke.de on 25 Jun 2011 at 10:51

@GoogleCodeExporter
Copy link
Author

Bump!

Original comment by omarshar...@gmail.com on 3 Aug 2011 at 7:09

@GoogleCodeExporter
Copy link
Author

sorry, i must have missed this earlier.
for the record, you can use the same code review mechanism for go-charset as 
for the
main go tree, but in this case the changes are so small i'll make them myself.

thanks for pointing it out.

Original comment by rogpeppe@gmail.com on 3 Aug 2011 at 9:08

@GoogleCodeExporter
Copy link
Author

"for the record, you can use the same code review mechanism for go-charset as 
for the
main go tree"

Sorry, not following you here, can you explain further?

Original comment by omarshar...@gmail.com on 3 Aug 2011 at 11:20

@GoogleCodeExporter
Copy link
Author

Expecting to see this 4-line change being made soon, as I am going to recommend 
this excellent package to some friends.

I guess it is not necessary, but anyway, here attaches a patch.

Original comment by Yi.Wang.2005 on 13 Aug 2011 at 2:07

Attachments:

@GoogleCodeExporter
Copy link
Author

sorry for the delay, i thought i'd submitted this ages ago!

Original comment by rogpeppe@gmail.com on 13 Aug 2011 at 2:42

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant