Test: Remove skip of static test case and fix options route test

chenjr0719 · Jun 20, 2019 · 86a8a4a · 86a8a4a
1 parent d65f0bb
commit 86a8a4a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/sanic_openapi/swagger.py b/sanic_openapi/swagger.py
@@ -99,7 +99,8 @@ def build_spec(app, loop):
         if route.uri.startswith(swagger_blueprint.url_prefix):
             continue
 
-        if "static" in route.name:
+        # route.name will be None when using class based view
+        if route.name and "static" in route.name:
             # TODO: add static flag in sanic routes
             continue
 

diff --git a/tests/test_swagger.py b/tests/test_swagger.py
@@ -257,9 +257,6 @@ def test_configs(app, configs):
     assert info["license"]["url"] == configs["API_LICENSE_URL"]
 
 
-@pytest.mark.skip(
-    reason="The uri '/static' still in swagger.json now. This might already fixed by #80."
-)
 def test_skip_static_file(app):
     app.static("/static", __file__)
 
@@ -294,4 +291,4 @@ def test(request):
     assert response.content_type == "application/json"
 
     swagger_json = response.json
-    assert swagger_json["paths"]["/"] == {}
+    assert swagger_json["paths"] == {}