Changed webpack renderer dev node config #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhen0409
approved these changes
Jun 4, 2017
amilajack
added a commit
that referenced
this pull request
Jul 9, 2017
* Renamed and alphabetized npm scripts (#1022) * Renamed and alphabetized npm scripts * Moved electron to deps from devDeps * Reverted flow-runtime changes, moved react-hot-loader/babel * Enforced immutability of redux actions and state using flow * Changed webpack renderer dev node config (#1035) * Increased timeout for e2e async test * Remove progress and profile flags from npm scripts for cleaner output * Removed babel-polyfill (#1052) * Removed babel-polyfill * Updated CI node versions * Required npm >= 4 * Enable yarn on CI * Fixed travis config spacing syntax error * Converted tabs to spaces on CI configs * Fixed duplicate key in appveyor config * Misc commit * Ignored node_modules from webpack dev-server watch * Updated deps (#1100) * Renamed webpack output filenames, fixed watchOptions of dev-server Warn if main or renderer not built before e2e tests (#1117) * Warn if main or renderer not built before e2e tests * Fixed linter errors Changed ordering of build and test scripts * Updated changelog [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jhen0409 @dustintownsend @talha131 @slapbox What do you think about this? I feel like this is what suites most apps. Its also pretty confusing to have
__dirnameand__filenamedefined differently in production. Would love your thoughts on this.