New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thanks for the effort to the repo, I made some super tiny enhancements for you to check #5
Conversation
This is all great, thank you so much for your contribution.
|
Maybe we should keep the snapshots in repo and reviewed as part of your code review process. As quote from
|
I got another issue with the plugin in truly project. When we using |
Our snapshots will be a bit special. The content involves file directories. Everyone’s device is different, and the project storage address is different, so there will be different answers. At the time, I didn’t think it was a big problem. |
Well, i'll add shots to .gitignore for this PR |
We are actually using base and publicpath as a match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the snapshots/ and add __snapshots__/
as git igored
@zhoujinfu Is it convenient to file an issue to discuss your problem? |
@zhoujinfu Thanks for your contribution, a new version has been released. |
vitest
.node-html-parser
asdep
to fix module NOT FOUND errors.import.env.LEGACY
undefined errors in plugin.configResolved reproduce with 9f2ace0 and fixed with aa2e90f.