Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-origin information is cached #33

Closed
nijinekoyo opened this issue Jul 12, 2023 · 4 comments
Closed

Cross-origin information is cached #33

nijinekoyo opened this issue Jul 12, 2023 · 4 comments
Assignees

Comments

@nijinekoyo
Copy link

When there are multiple cross-domain domain names that allow cross-domain information, it will cause confusion when the cross-domain information is cached. It is hoped that the cross-domain return header can be ignored during caching

@nijinekoyo nijinekoyo reopened this Jul 12, 2023
@chenyahui chenyahui self-assigned this Jul 24, 2023
@chenyahui
Copy link
Owner

@nijinekoyo Sorry for the delayed response. I have added a new option called "DiscardHeaders" and included "CorsHeaders" in the library. You can take a look at the commit to see if it meets your requirements.
a2f9e2b

@nijinekoyo
Copy link
Author

nijinekoyo commented Nov 16, 2023

Wow, thank you so much for solving this problem

This way I can remove the WithoutHeader() function. Very much looking forward to the release of this version.

@chenyahui
Copy link
Owner

I released v1.9.0 for this feature.

Just a reminder, please make sure to confirm if everything meets your expectations and conduct thorough testing before using it in a production environment.

https://github.com/chenyahui/gin-cache/blob/main/cache_test.go#L246

@nijinekoyo
Copy link
Author

I successfully fixed the problem, thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants