Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add base endpoints for Stripe integration [DEV-3671] #500

Merged
merged 23 commits into from
Apr 11, 2024

Conversation

lampkin-diet
Copy link
Contributor

No description provided.

@ankurdotb
Copy link
Contributor

Copy link

cloudflare-pages bot commented Mar 20, 2024

Deploying credential-service with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab0da5b
Status:🚫  Build failed.

View logs

@Tweeddalex
Copy link
Contributor

Hey @lampkin-diet could you please take a look at why the build is failing here :)

Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid + great usage of decorators ensuring synchronisation with external data points.

Let's address the remarks, which should be straightforward, before promoting the work.

src/controllers/admin/webhook.ts Outdated Show resolved Hide resolved
src/controllers/admin/webhook.ts Outdated Show resolved Hide resolved
src/controllers/admin/webhook.ts Outdated Show resolved Hide resolved
src/controllers/admin/webhook.ts Outdated Show resolved Hide resolved
src/middleware/auth/base-auth-handler.ts Outdated Show resolved Hide resolved
src/middleware/auth/user-info-fetcher/portal-token.ts Outdated Show resolved Hide resolved
src/services/track/helpers.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well polished.

Approved.

@lampkin-diet lampkin-diet merged commit 99792c7 into develop Apr 11, 2024
14 checks passed
@lampkin-diet lampkin-diet deleted the DEV-3671 branch April 11, 2024 11:28
cheqd-bot bot pushed a commit that referenced this pull request Apr 11, 2024
## [2.20.0-develop.1](2.19.1-develop.1...2.20.0-develop.1) (2024-04-11)

### Features

* Add base endpoints for Stripe integration [DEV-3671] ([#500](#500)) ([99792c7](99792c7))
@cheqd-bot
Copy link

cheqd-bot bot commented Apr 11, 2024

🎉 This PR is included in version 2.20.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Apr 18, 2024
## [2.20.0](2.19.0...2.20.0) (2024-04-18)

### Features

* Add API key endpoints [DEV-3793] ([#510](#510)) ([c237502](c237502))
* Add base endpoints for Stripe integration [DEV-3671] ([#500](#500)) ([99792c7](99792c7))
* Add endpoints for organisation page [DEV-3848] ([#522](#522)) ([b5de42b](b5de42b))

### Bug Fixes

* Add customerId into operation entity [DEV-3732] ([#507](#507)) ([b580646](b580646))
* Reject unauthorised users for /admin/swagger page ([#523](#523)) ([51f800b](51f800b))
@cheqd-bot
Copy link

cheqd-bot bot commented Apr 18, 2024

🎉 This PR is included in version 2.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants