Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Credential Service Staging - Resolve issue with page not loading and broken login [DEV-3162] #358

Merged
merged 8 commits into from
Aug 29, 2023

Conversation

abdulla-ashurov
Copy link
Contributor

  • Resolve issue with page not loading.
  • Fix broken login.

because this custom method is written incorrectly and doesn't allow to
show swagger.json in SwaggerUI.
@abdulla-ashurov abdulla-ashurov added the bug Something isn't working label Aug 28, 2023
@abdulla-ashurov abdulla-ashurov self-assigned this Aug 28, 2023
@ankurdotb
Copy link
Contributor

Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

I've left a comprehensive list of notes on why monkey patching is necessary for encryption conditions succeeding, until either @verida/encryption-utils removes their json stringify replacement or we get rid of verida functionality / packages altogether.

Could you restore it instead of removing it?

@abdulla-ashurov
Copy link
Contributor Author

abdulla-ashurov commented Aug 28, 2023

Thanks for looking into this.

I've left a comprehensive list of notes on why monkey patching is necessary for encryption conditions succeeding, until either @verida/encryption-utils removes their json stringify replacement or we get rid of verida functionality / packages altogether.

Could you restore it instead of removing it?

Restored and commented for now! ✅

lampkin-diet
lampkin-diet previously approved these changes Aug 29, 2023
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with various enhancements.

Thanks!

@Eengineer1 Eengineer1 merged commit 419d2ec into develop Aug 29, 2023
15 checks passed
@Eengineer1 Eengineer1 deleted the DEV-3162 branch August 29, 2023 15:19
cheqd-bot bot pushed a commit that referenced this pull request Aug 29, 2023
## [2.9.0-develop.5](2.9.0-develop.4...2.9.0-develop.5) (2023-08-29)

### Bug Fixes

* Credential Service Staging - Resolve issue with page not loading and broken login [DEV-3162] ([#358](#358)) ([419d2ec](419d2ec))
@cheqd-bot
Copy link

cheqd-bot bot commented Aug 29, 2023

🎉 This PR is included in version 2.9.0-develop.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Aug 29, 2023
## [2.9.0](2.8.0...2.9.0) (2023-08-29)

### Features

* Added encrypted StatusList APIs + enhanced type safety ([#350](#350)) ([951e2b4](951e2b4))
* Change from `did/:did` to `did/search/:didUrl` endpoint and support query parameters for DID endpoint in Credential Service [DEV-3097] ([#331](#331)) ([4e34b76](4e34b76))

### Bug Fixes

* Credential Service Staging - Resolve issue with page not loading and broken login [DEV-3162] ([#358](#358)) ([419d2ec](419d2ec))
* Fix problem with agent initialize [DEV-3146] ([#346](#346)) ([45e1074](45e1074))
* Validate did access on operation ([#351](#351)) ([8bbfce1](8bbfce1))
@cheqd-bot
Copy link

cheqd-bot bot commented Aug 29, 2023

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants