Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support did:vda in validator [DEV-3498] #459

Merged
merged 7 commits into from
Jan 5, 2024
Merged

fix: Support did:vda in validator [DEV-3498] #459

merged 7 commits into from
Jan 5, 2024

Conversation

DaevMithran
Copy link
Contributor

No description provided.

@DaevMithran DaevMithran force-pushed the verida-did branch 4 times, most recently from cce2b8d to 0283acc Compare January 5, 2024 05:58
@DaevMithran DaevMithran force-pushed the verida-did branch 4 times, most recently from 4c55e8c to 86e976d Compare January 5, 2024 07:02
@DaevMithran DaevMithran force-pushed the verida-did branch 2 times, most recently from 696ff0a to 8b141e7 Compare January 5, 2024 09:05
@Tweeddalex Tweeddalex changed the title fix: Support did:vda in validator fix: Support did:vda in validator [DEV-3498] Jan 5, 2024
@ankurdotb
Copy link
Contributor

Task linked: DEV-3498 Fix issue with did:vda not being supported in credential/issue

Eengineer1
Eengineer1 requested changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core work + tests look good.

Please, resolve assessing the validation suggestion, before that's good to merge.

src/controllers/credentials.ts Outdated Show resolved Hide resolved
DaevMithran and others added 2 commits January 5, 2024 15:22
@DaevMithran @Eengineer1
Switch to truthy evaluation
bad3a8b 
Co-authored-by: Tasos Derisiotis <50984242+Eengineer1@users.noreply.github.com>
@DaevMithran
Merge branch 'develop' into verida-did
8929c7f
@DaevMithran DaevMithran merged commit 2176e84 into develop Jan 5, 2024
13 of 14 checks passed
@DaevMithran DaevMithran deleted the verida-did branch January 5, 2024 10:00
cheqd-bot bot pushed a commit that referenced this pull request Jan 5, 2024
@semantic-release-bot
chore(release): 2.15.0-develop.2 [skip ci]
d3b385f 
## [2.15.0-develop.2](2.15.0-develop.1...2.15.0-develop.2) (2024-01-05)

### Bug Fixes

* Support did:vda in validator [DEV-3498] ([#459](#459)) ([2176e84](2176e84))
@cheqd-bot
Copy link

cheqd-bot bot commented Jan 5, 2024

🎉 This PR is included in version 2.15.0-develop.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Jan 5, 2024
@semantic-release-bot
chore(release): 2.15.0 [skip ci]
814c2f2 
## [2.15.0](2.14.0...2.15.0) (2024-01-05)

### Features

* Add did import api [DEV-3487] ([#457](#457)) ([75232f0](75232f0))

### Bug Fixes

* Removed redundant import ([6f10d61](6f10d61))
* Support did:vda in validator [DEV-3498] ([#459](#459)) ([2176e84](2176e84))
@cheqd-bot
Copy link

cheqd-bot bot commented Jan 5, 2024

🎉 This PR is included in version 2.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Eengineer1 requested changes

Assignees
No one assigned
Labels
released on @beta released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaevMithran @ankurdotb @Eengineer1