Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photometry table in 'Source.py' #13

Open
ppathak8 opened this issue Jan 6, 2024 · 5 comments
Open

Photometry table in 'Source.py' #13

ppathak8 opened this issue Jan 6, 2024 · 5 comments

Comments

@ppathak8
Copy link
Contributor

ppathak8 commented Jan 6, 2024

  • Just a comment, the zero point value for the I-band is 30% more compared to what I get in my calculation.
  • The values for other I-filters (I1, I2, I3, ..), seems to be fixed: 2.7e12
  • elsewhere in the code I don't see the use of filter bandwidth, which can account for this discrepancy.

Can you let me know, if I am missing something?

@cheritier
Copy link
Owner

Hi,
_ The values were imported from the OOMAO standard photometry class so there might be a few discrepancy, especially on the zero-point (We usually consider the number of photon per sub-aperture, not so much the magnitude).
_ The bandwidth is indeed not used in the code, everything is considered to be monochromatic around the central wavelenght specified in the photometry class.
_ if you need, you can also redefine another photometry class with your own values

@ppathak8
Copy link
Contributor Author

Yes, I had looked up OOMAO, and I found the same there as well.

  • The number of photons will vary with magnitude, which is correctly calculated.
  • If it is monochromatic then it's fine, but this will impact the correct value of photons per sub-aperture you get for other bands of "I".

@cheritier
Copy link
Owner

Indeed,
If you have the correct values, feel free to create a pull request to update the current values.

@ppathak8
Copy link
Contributor Author

Will do it in the coming months.

@torin5
Copy link
Contributor

torin5 commented Jun 20, 2024

Hi there, It seems this change introduced a couple indentation errors in Source.py. I made a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants