You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the Pyramid class is instantiated with a non null userValidSignal argument, if self.postProcessing="slopesMaps" the initialization will set self.validI4Q with the provided array (L400). This could be misleading since the class attribute self.validSignal is then set with the concatenation of self.validI4Q with itself, which will result in self.validSignal having double the size if the user provided what is supposed to be the final valid signal array.
Fix
Possibly set self.validSignal = self.userValidSignal, thus replicating the logic used for self.postProcessing="fullFrame". If it is of interest to maintain the possibility of the user providing what effectively is self.validI4Q , one option would be to try to infer which case it is based on the intensity maps (and possibly also validate the shape/dimension of user-provided mask).
The text was updated successfully, but these errors were encountered:
Description
When the Pyramid class is instantiated with a non null
userValidSignal
argument, ifself.postProcessing="slopesMaps"
the initialization will setself.validI4Q
with the provided array (L400). This could be misleading since the class attributeself.validSignal
is then set with the concatenation ofself.validI4Q
with itself, which will result inself.validSignal
having double the size if the user provided what is supposed to be the final valid signal array.Fix
Possibly set
self.validSignal = self.userValidSignal
, thus replicating the logic used forself.postProcessing="fullFrame"
. If it is of interest to maintain the possibility of the user providing what effectively isself.validI4Q
, one option would be to try to infer which case it is based on the intensity maps (and possibly also validate the shape/dimension of user-provided mask).The text was updated successfully, but these errors were encountered: