Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading attribute "userValidSignal" in Pyramid class #4

Open
joao-aveiro opened this issue Dec 7, 2022 · 0 comments
Open

Misleading attribute "userValidSignal" in Pyramid class #4

joao-aveiro opened this issue Dec 7, 2022 · 0 comments

Comments

@joao-aveiro
Copy link
Contributor

Description

When the Pyramid class is instantiated with a non null userValidSignal argument, if self.postProcessing="slopesMaps" the initialization will set self.validI4Q with the provided array (L400). This could be misleading since the class attribute self.validSignal is then set with the concatenation of self.validI4Q with itself, which will result in self.validSignal having double the size if the user provided what is supposed to be the final valid signal array.

Fix

Possibly set self.validSignal = self.userValidSignal, thus replicating the logic used for self.postProcessing="fullFrame". If it is of interest to maintain the possibility of the user providing what effectively is self.validI4Q , one option would be to try to infer which case it is based on the intensity maps (and possibly also validate the shape/dimension of user-provided mask).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant