Cherokee compilation fails in sunstudio due to improper PRINT_ERROR usage

[danielniccoli]

Original author: kallist...@gmail.com (May 27, 2009 16:29:26)

What steps will reproduce the problem?
http://jucr.opensolaris.org/review/packages/634/

What is the expected output? What do you see instead?
pkgbuild: /opt/SUNWspro/bin/cc -DHAVE_CONFIG_H -I. -I.. -I.. -mt -g -c
spawner.c -KPIC -DPIC -o .libs/libcherokee_server_la-spawner.o
pkgbuild: "/usr/include/sys/stat.h", line 451: warning: macro redefined:
S_ISLNK
pkgbuild: "spawner.c", line 228: warning: argument mismatch
pkgbuild: "spawner.c", line 228: syntax error before or at: )
pkgbuild: "spawner.c", line 250: cannot recover from previous errors
pkgbuild: cc: acomp failed for spawner.c

What version of the product are you using? On what operating system?
OpenSolaris source Juicer

Please provide any additional information below.

Found the bug,
spawner.c, line 228 is:
PRINT_ERROR("WARNING: Couldn't unlock spawning semaphore..\n");

Should be:
PRINT_ERROR_S("WARNING: Couldn't unlock spawning semaphore..\n");

PRINT_ERROR is expecting two arguments, not sure why gcc misses that and
sunstudio catches it though.

Original issue: http://code.google.com/p/cherokee/issues/detail?id=483

[danielniccoli]

From alobbs on May 27, 2009 16:55:10
It should be fixed now:
http://svn.cherokee-project.com/changeset/3268

Alexander, thanks for reporting!