Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.7 and earlier #633

Merged
merged 3 commits into from May 20, 2023
Merged

Drop support for Python 3.7 and earlier #633

merged 3 commits into from May 20, 2023

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented May 20, 2023 •
edited by webknjaz

Fixes #565.

This change is Reviewable

webknjaz
webknjaz reviewed May 20, 2023
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides those two notes, the rest looks good to me.

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Show resolved Hide resolved
@jaraco jaraco merged commit f82aee6 into main May 20, 2023
93 of 94 checks passed
@jaraco jaraco deleted the debt/drop-py37 branch May 20, 2023 17:20
@webknjaz webknjaz mentioned this pull request May 22, 2023
Merged
webknjaz added a commit to webknjaz/cheroot that referenced this pull request Apr 17, 2024
@webknjaz
Revert "Merge pull request cherrypy#633 from cherrypy/debt/drop-py37"
7e728b5 
This reverts commit f82aee6, reversing
changes made to 2b3b3eb.
webknjaz added a commit to webknjaz/cheroot that referenced this pull request Apr 17, 2024
@webknjaz
Revert "Merge pull request cherrypy#633 from cherrypy/debt/drop-py37"
b1f7384 
This reverts commit f82aee6, reversing
changes made to 2b3b3eb.
webknjaz added a commit to webknjaz/cheroot that referenced this pull request Apr 17, 2024
@webknjaz
Revert "Merge pull request cherrypy#633 from cherrypy/debt/drop-py37"
688fc83 
This reverts commit f82aee6, reversing
changes made to 2b3b3eb.
webknjaz added a commit that referenced this pull request Apr 22, 2024
@webknjaz
Reapply "Merge pull request #633 from cherrypy/debt/drop-py37"
62acde5 
This reverts commit 688fc83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7
2 participants
@jaraco @webknjaz