Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the pdf with the one compiled by pdflatex #1933

Merged
merged 2 commits into from Feb 1, 2022

Conversation

krysros
Copy link
Contributor

@krysros krysros commented Sep 13, 2021

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Reduce the size of the wheel file by replacing the sample pdf file in the tutorial with a smaller one (84 KB -> 12 KB).

Other information:

PDF file compiled by pdflatex from:

\documentclass{article}
\begin{document}
    Hi 
\end{document}

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@webknjaz webknjaz merged commit 4540384 into cherrypy:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants