-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some questions about the pytorch version #31
Comments
Yes, it is. It is due to that PyTorch changed the behavior of the division function. I remembered that I fixed the bug and you can update your code. For the old version, the performance will be dramatically dropped from 66.5 to 40+ for the official model. |
Thanks for your reply. I have tried to change the code. Any other codes should be changed? |
Have you trained the model again after fixing the bug? |
I have retrained the model before fixing it. |
How about the evaluation results? |
I added some extra data augmentation, and the results are slightly better than the paper reported in torch1.3.1. |
Maybe some other changes in PyTorch lead to your results. In recent days, I have extensively trained many models with PyTorch-1.10. I did not have observed any incorrect results on my side after fixing the abovementioned bug as you did. |
Thanks. I think that the model needs to be retrained in a new PyTorch version. |
Yes, it should be retrained. |
Results from pytorch1.9 have more disorderly lines compared with ones from pytorch1.3.1.
![image](https://user-images.githubusercontent.com/12042259/159444269-4388d0fb-08e6-4a7d-aa53-5ebaff6fdb9f.png)
Are there any bugs for it?
Lines from pytorch1.9:
Lines from pytorch1.3.1:
![image](https://user-images.githubusercontent.com/12042259/159444323-91df2c74-4eaf-4727-b9da-371da8514087.png)
My HAWP model was trained in pytorch1.3.1
The text was updated successfully, but these errors were encountered: