Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test the /castling command #40

Closed
programarivm opened this issue Sep 29, 2021 · 1 comment · Fixed by #53
Closed

Unit test the /castling command #40

programarivm opened this issue Sep 29, 2021 · 1 comment · Fixed by #53
Labels

Comments

@programarivm
Copy link
Member

This issue is intended to practice software architecture skills as well as unit testing.

As you may have noted, there's a one-to-one correspondence between the Chess\Game methods described in the PHP Chess Docs and the commands available in the chess server:

  • ascii(): string <-> ChessServer\Command\AsciiCommand.php
  • captures(): array <-> ChessServer\Command\CapturesCommand.php
  • castling(): ?array <-> ChessServer\Command\CastlingCommand.php
  • ...

All commands should be unit tested in ChessServer\Tests\Unit\Command. However, the ChessServer\Tests\Unit\Command\CastlingTest.php file is missing.

The missing file should be added as per the existing conventions.

Happy learning and coding!

@Pen-y-Fan
Copy link
Contributor

Hi there, happy learning and coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants