Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDD the Chess\Eval\CombinedAttackEval class #528

Closed
programarivm opened this issue Apr 28, 2024 · 1 comment · Fixed by #541
Closed

TDD the Chess\Eval\CombinedAttackEval class #528

programarivm opened this issue Apr 28, 2024 · 1 comment · Fixed by #541
Assignees

Comments

@programarivm
Copy link
Member

programarivm commented Apr 28, 2024

A new evaluation feature called Chess\Eval\CombinedAttackEval needs to be implemented in the php-chess/src/Eval folder. The PHPUnit tests are to be written in the php-chess/tests/unit/Eval/CombinedAttackEvalTest.php file accordingly. This is for when multiple pieces are targeting one of the opponent's pieces simultaneously.

@programarivm
Copy link
Member Author

programarivm commented Apr 30, 2024

Rather than implementing a new evaluation feature, it looks like it is the threat evaluation what needs to be fixed. The threat evaluation is working correctly in many positions when a piece is at risk of being lost. The signal though is not triggered in the position below. The king alone seems not to be taken into consideration as a defending piece.

chessboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant