Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the notices that are thrown when loading an invalid FEN #83

Closed
programarivm opened this issue Oct 6, 2021 · 3 comments · Fixed by #86
Closed

Fix the notices that are thrown when loading an invalid FEN #83

programarivm opened this issue Oct 6, 2021 · 3 comments · Fixed by #86
Assignees
@bofalke
Labels
hacktoberfest

Comments

@programarivm
Copy link
Member

See chesslablab/chess-server#33
@programarivm
Copy link
Member Author

Probably it makes sense to unit test this issue.

Let's TDD a few FEN strings (foo, bar, etc.) in tests/unit/FEN/StringToBoardTest.php and then refactor StringToBoard.php accordingly.

Thanks! Happy coding.

@rafael-neris
Copy link
Contributor

Heey, @programarivm, can I pick up this issue? I'm loving this repository. Thank you!

@bofalke bofalke mentioned this issue Oct 7, 2021
Merged
@programarivm
Copy link
Member Author

programarivm commented Oct 7, 2021 •
edited

Thank you for contributing to this repo!

Sorry that on this occasion this issue was assigned to @bofalke

Keep it up, and happy learning and coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bofalke bofalke

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine FEN/StringToBoard bofalke/php-chess
3 participants
@programarivm @bofalke @rafael-neris