Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlightr No Longer Working w Obsidian v0.15.3 #41

Open
Paddy1058 opened this issue Jun 29, 2022 · 5 comments
Open

Highlightr No Longer Working w Obsidian v0.15.3 #41

Paddy1058 opened this issue Jun 29, 2022 · 5 comments

Comments

@Paddy1058
Copy link

I was enjoying using Highlightr, but it no longer works. Only thing I can identify is recent update to Ob v0.15.3. Have tried uninstalling and reinstalling plugin.

Anyone else having this problem? Solutions?

@chetachiezikeuzor
Copy link
Owner

I apologize for the lack of updates to this plugin. I will take a look at this tonight and see what I can do. Thank you for your patience!

@Paddy1058
Copy link
Author

Paddy1058 commented Jul 5, 2022

FYI, I found a partial work a round -- by setting hotkeys for the various colors, I can now again add highlights. But setting a hot key to open the highlightr doesn't work -- it just doesn't respond, and doesn't display the choice of colors. Also, to unlighlight, right-clicking on the highlight doesn't bring up the unhighlight menu, but raises a note that "focus must be in editor" (I'm using live preview). Clicking on the highlight puts it in edit mode, then right-clicking brings up unhighlight option, and clicking then unhighlights. Hope this may help in troubleshooting. Really like this plugin when it was working normally. p.s. I'm using Blue Topaz theme; tried another one, Nick Milo's and it didn't make a difference. p.s. Updated Obsidian to v0.15.4, still same problem.

@Paddy1058
Copy link
Author

Paddy1058 commented Jul 20, 2022

I found another factor affecting this plugin: whether the Obsidian css is turned on or off in Settings/Appearance, down at the bottom of the page. If it is turned on, then the highlight appears but is not the chosen color. Turning the css off then allows the chosen color highlight to appear -- although still very limited, as described above. Of course, this might depend on the css file in the vault.

@remerle
Copy link

remerle commented Aug 3, 2022

I have a workaround, and possibly a starting point for @chetachiezikeuzor's investigation. It seems the Obsidian API expects you to play nice with their context menus, so I suspect a fix would require using the menu.addItem method rather than overwriting the dom.

You can find the crude workaround here: #42 (comment)

@Paddy1058
Copy link
Author

Yup, fix works -- see #42 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants