Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body overwritten when --body not specified #8

Closed
dougnorton opened this issue Apr 4, 2019 · 2 comments · May be fixed by retorquere/zotero-bulk-mas-import#6 or retorquere/zotero-creator-metaphone#5

Comments

@dougnorton
Copy link

We call upload from multiple build machines for each release. Only one of those uploads contain a body. Any call to upload that doesn't include a body causes the body of the release to be overwritten with an empty string. Could you not write body if it's empty? For example:

case 22:
	var data = {
		owner: owner,
		repo: repo,
		release_id: release.id,
		tag_name: tag,
		name: name || tag,
		draft: draft === undefined ? !!release.draft : false,
		prerelease: prerelease === undefined ? !!release.prerelease : false
	};
	var body = (body === undefined ? release.body || '' : body || '');
	
	if(body !== '')
		data['body'] = body;
	console.log('> updateRelease: release_id=' + release.id + ', tag_name=' + tag + ', name=' + (name || tag));
	_context.next = 25;
	return octokit.repos.updateRelease(data);
@cheton
Copy link
Owner

cheton commented Apr 4, 2019

Thank you for reporting this issue. It shall be fixed in 1.1.0.

@dougnorton
Copy link
Author

thank-you, works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants