Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on android if user is in a locale that uses comma for decimal separator #13

Closed
chetstone opened this issue Oct 31, 2019 · 1 comment
Closed

Crash on android if user is in a locale that uses comma for decimal separator #13

chetstone opened this issue Oct 31, 2019 · 1 comment
Assignees
@chetstone
Labels
bug

Comments

@chetstone
Copy link
Owner

chetstone commented Oct 31, 2019 •
edited

When converting android ARGB colors to rgba, java uses the locale setting for decimal separator, resulting in a corrupt rgba string, e.g: rgba(255,255,255,0,663), if the user is in a locale that uses comma for a decimal separator.

It should be rgba(255,255,255,0.663)

Javascript code that processes this value, expecting a valid rgba string, can crash.
@chetstone chetstone self-assigned this Oct 31, 2019
@chetstone chetstone added the bug label Oct 31, 2019
@chetstone
Copy link
Owner Author

Fixed in commit 837090c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chetstone chetstone

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chetstone