Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken diagram generation in 7.0.0 #1186

Closed
danhawkes opened this issue Apr 21, 2020 · 3 comments
Closed

Broken diagram generation in 7.0.0 #1186

danhawkes opened this issue Apr 21, 2020 · 3 comments
Labels

Comments

@danhawkes
Copy link

A diagram that was working in 6.5.0 seems to have stopped working in 7.0.0.
Attached samples seem to show the only non-whitespace change is this:

diff --git a/6.5.0.txt b/7.0.0.txt
index 0deb9ac..47206d1 100644
--- a/6.5.0.txt
+++ b/7.0.0.txt
@@ -98,7 +98,7 @@
             "idx": 0,
             "definition": [
               {
-                "type": "Flat",
+                "type": "Alternative",
                 "definition": [
                   {
                     "type": "Terminal",
@@ -109,7 +109,7 @@
                 ]
               },
               {
-                "type": "Flat",
+                "type": "Alternative",
                 "definition": [
                   {
                     "type": "Terminal",
@@ -120,7 +120,7 @@
                 ]
               },
               {
-                "type": "Flat",
+                "type": "Alternative",
                 "definition": [
                   {
                     "type": "Terminal",

6.5.0.txt
7.0.0.txt
(Rename .txt -> .html)

@bd82
Copy link
Member

bd82 commented Apr 21, 2020

Thanks for reporting this, I must have missed something in the renaming of Flat to Alternative

@bd82 bd82 added the Bug 🪲 label Apr 21, 2020
@bd82 bd82 closed this as completed in 287b900 Apr 21, 2020
@bd82
Copy link
Member

bd82 commented Apr 22, 2020

@danhawkes please try version 7.0.1 (out on npm).

Cheers.

@danhawkes
Copy link
Author

Yep, that's fixed it! Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants