Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid rebuilding the GAST on parser construction when using RULE_OVERRIDE #171

Closed
bd82 opened this issue Apr 7, 2016 · 1 comment
Closed

Avoid rebuilding the GAST on parser construction when using RULE_OVERRIDE #171

bd82 opened this issue Apr 7, 2016 · 1 comment

Comments

@bd82
Copy link
Member

bd82 commented Apr 7, 2016

See comment in:
https://github.com/SAP/chevrotain/blob/13cc2eee7caa00bc8780d3a16e951e681f6515d4/src/parse/parser_public.ts#L1083
@bd82 bd82 changed the title avoid rebuilding the GAST on parser construction when using RULE_OVERRIDE Avoid rebuilding the GAST on parser construction when using RULE_OVERRIDE Apr 9, 2016
@bd82
Copy link
Member Author

bd82 commented Apr 9, 2016

Will avoid doing "heavy duty" lifting every time a Parser using RULE_OVERRIDE is initialized.
The heavy lifting (analyzing the grammar) should only be done the first time a Parser is initialized.

bd82 pushed a commit that referenced this issue Apr 9, 2016
Cache information if a grammar production has already been overriden
26d95c6 
in the context of a specific grammar.

This enables avoiding the rebuilding of the GAST representation
of an overriden rule on each and every initialization of the Parser.

Fixes #171
@bd82 bd82 mentioned this issue Apr 9, 2016
Merged
@bd82 bd82 closed this as completed in #180 Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bd82