Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser Configuration should be done using a "Config" Object instead of constructor parameters. #175

Closed
bd82 opened this issue Apr 8, 2016 · 0 comments
Closed

Parser Configuration should be done using a "Config" Object instead of constructor parameters. #175

bd82 opened this issue Apr 8, 2016 · 0 comments

Comments

@bd82
Copy link
Member

bd82 commented Apr 8, 2016

Currently there is only one optional parameter (errorRecoveryEnabled).
However in the future there may be more (max errors / custom lexer / ??? /) optional parameters and supporting a mix of optional (by index) parameters simply does not scale.

This will be an API breaking change.
bd82 pushed a commit that referenced this issue Apr 8, 2016
Error Recovery / Fault Tolerance abilities should be disabled by defa…
e6803c8 
…ult.

Parser Configuration should be done using a
"Config" Object instead of constructor parameters.

Fixes #175
Fixes #174
@bd82 bd82 mentioned this issue Apr 8, 2016
Merged
bd82 pushed a commit that referenced this issue Apr 8, 2016
Error Recovery / Fault Tolerance abilities should be disabled by defa…
5096e6b 
…ult.

Parser Configuration should be done using a
"Config" Object instead of constructor parameters.

Fixes #175
Fixes #174
bd82 pushed a commit that referenced this issue Apr 8, 2016
Error Recovery / Fault Tolerance abilities should be disabled by defa…
c3caf40 
…ult.

Parser Configuration should be done using a
"Config" Object instead of constructor parameters.

Fixes #175
Fixes #174
bd82 pushed a commit that referenced this issue Apr 8, 2016
Error Recovery / Fault Tolerance abilities should be disabled by defa…
0725430 
…ult.

Parser Configuration should be done using a
"Config" Object instead of constructor parameters.

Fixes #175
Fixes #174
@bd82 bd82 closed this as completed in #176 Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bd82